Re: RM4939 - Running in the container as non-root user

From: Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: RM4939 - Running in the container as non-root user
Date: 2019-12-09 05:09:59
Message-ID: CAJFwRrMA+FHaqhHeYVCzbm+MYt33Vg_DvwwTGinvXhMJfonazg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Verification has been completed, now you can commit this patch.

On Wed, Dec 4, 2019 at 2:16 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Dave
>
> I have reviewed the code and tested the basic scenario. The code looks
> good to me. I have verified that the user is pgadmin with user id 5050.
>
> With your patch Without applying
> your patch
> [image: NonRootUser.png] [image: RootUser.png]
>
> @Fahar please test upgrades mostly when using mapped storage or session
> data.
>
> On Wed, Dec 4, 2019 at 8:21 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> The attached patch fixes $SUBJECT. I'm a little concerned about upgrades
>> though, mostly when using mapped storage or session data. Fahar, can you
>> test such scenarios please?
>>
>> Patch review is also needed please :-)
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Fahar Abbas
QMG
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: *live:fahar.abbas*
Website: www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-12-09 05:40:05 pgAdmin 4 commit: Run pgAdmin in the container as a non-root user (pgad
Previous Message Akshay Joshi 2019-12-09 05:02:57 Re: Japanese translation (December 2019)