Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

Hi Akshay,

Please find the attached patch for below issues:
1) The volatility option is not reflecting. It stays volatile always when
creating the function - Fixed
2) Set "Returns as set" to true and enter estimated rows like 12. Now set
returns as set to false and save. It gives ERROR: ROWS is not applicable
when function does not return a set. Need to clear estimated rows when
returns as set is false. - Fixed
3) If estimated rows are added and support function is selected then SQL
looks ugly. - Fixed

On Mon, Oct 5, 2020 at 2:41 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Thanks, patch applied.
>
> On Thu, Oct 1, 2020 at 2:25 PM Pradip Parkale <
> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>
>> Hi Akshay,
>>
>> Please find the attached patch to allow the user to modify the option
>> settings of the procedure. This issue was only for PPAS 11 and PPAS 12.
>>
>> On Wed, Sep 23, 2020 at 11:30 PM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Akshay,
>>>
>>> Please find the small patch for the ' Parallel Unsafe' option is missing
>>> in SQL. It was missing in first patch for PG96 and PG10.
>>>
>>>
>>> On Wed, Sep 23, 2020 at 1:25 PM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Thanks, patch applied. It's a small fix so I have fixed it.
>>>>
>>>> On Wed, Sep 23, 2020 at 12:14 PM Akshay Joshi <
>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Pradip
>>>>>
>>>>> RESQL tests are failing on EPAS 9.5, 9.6, and 10. Please fix and
>>>>> resend the patch.
>>>>>
>>>>> On Tue, Sep 22, 2020 at 6:41 PM Pradip Parkale <
>>>>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> The 'Unsafe' parallel option was not visible in the SQL for function
>>>>>> and procedure. Attached is the patch to fix this issue.
>>>>>>
>>>>>> --
>>>>>> Thanks & Regards,
>>>>>> Pradip Parkale
>>>>>> Software Engineer | EnterpriseDB Corporation
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>> *pgAdmin Hacker | Sr. Software Architect*
>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>> *pgAdmin Hacker | Sr. Software Architect*
>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation