Re: [pgAdmin][SonarQube]: Cognitive complexity

Hi Akshay,
Please find the updated patch.

On Fri, Aug 21, 2020 at 11:53 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Pradip
>
> Following are the review comments:
>
> - Change the function name to "_get_supported_browser" instead of
> "_get_browser_supported".
>
> Fixed.

>
> - Added docstring to the functions in below format:
>
> """
>
> <description>
>
> :param trans_id:
> :param session_obj:
> :param diff_model_obj:
> :return:
> """
>
> Fixed.

>
> - Can we make "_check_cascade_operation" to generic or move that
> function to PGChildNodeView class and update it in all the nodes where it
> is used.
>
> Fixed.

>
> -
>
>
> On Thu, Aug 20, 2020 at 8:56 PM Pradip Parkale <
> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>
>> Please ignore the previous patch, find the updated patch in this mail.
>>
>> On Thu, Aug 20, 2020 at 8:52 PM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> The attached patch will reduce cognitive complexity for the following
>>> functions.
>>>
>>> 1. web/.../databases/schemas/domains/__init__.py - 16 to 15.
>>> 2. web/.../tables/row_security_policies/__init__.py - 17 to 15.
>>> 3. web/pgadmin/tools/debugger/__init__.py - 23 to 15
>>> 4. user_mapping/__init__.py. 35 to 15.
>>> 5. browser/__init__.py.
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation