From: | Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM6677 & RM6632] [React] Port Procedure and Function node to react |
Date: | 2021-09-30 10:43:13 |
Message-ID: | CAJ9T6Stg_oyc6aOpj=c4kOZYmuM3OjBLow-tUyT68-fD+PmPAQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
Please find the attached patch for #6838 and #6841.
Issues are:
1. System procedure should not be visible in the properties tab for
function.
2. Estimated cost option should be editable in edit mode for Procedure.
3. Should give an error when language is not specified.
On Thu, Aug 26, 2021 at 12:22 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Thanks, the patch applied.
>
> On Thu, Aug 26, 2021 at 11:53 AM Pradip Parkale <
> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>
>> Hi Akshay,
>>
>> Please find the attached patch. I have improved the code coverage of
>> Function node and also fixed the test cases which were failing for Cast
>> ,Subscription and Publication node.
>>
>> On Tue, Aug 24, 2021 at 10:54 AM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch for RM6677 and RM6632 [React] Port
>>> Procedure and Function node to react.
>>>
>>> Also Updated a few test cases for previous ported nodes.
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachment | Content-Type | Size |
---|---|---|
RM6838.patch | application/octet-stream | 1.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2021-09-30 10:59:54 | pgAdmin 4 commit: 1) System procedure should not be visible in the prop |
Previous Message | Akshay Joshi | 2021-09-30 10:02:00 | Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue |