| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Vitaly Davydov <vitprof(at)gmail(dot)com>, Давыдов Виталий <v(dot)davydov(at)postgrespro(dot)ru> |
| Subject: | Re: How to accurately determine when a relation should use local buffers? |
| Date: | 2023-11-24 12:51:59 |
| Message-ID: | CAJ7c6TPso_SqmAooUJCu5gXdM68YPjnt4KS80zTdCq0pLpb1cA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> There are some changes in ReadBuffer logic if to compare with pg15. To define which buffers to use, ReadBuffer used SmgrIsTemp function in pg15. The decision was based on backend id of the relation. In pg16 the decision is based on relpersistence attribute, that caused some problems on my side. My opinion, we should choose local buffers based on backend ids of relations, not on its persistence. Additional check for relpersistence prior to backend id may improve the performance in some cases, I think. The internal design may become more flexible as a result.
Well even assuming this patch will make it to the upstream some day,
which I seriously doubt, it will take somewhere between 2 and 5 years.
Personally I would recommend reconsidering this design.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubham Khanna | 2023-11-24 13:07:37 | Re: Improve tab completion for ALTER DEFAULT PRIVILEGE and ALTER TABLE |
| Previous Message | Alvaro Herrera | 2023-11-24 12:27:56 | Re: remaining sql/json patches |