| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
| Subject: | Re: POC: Extension for adding distributed tracing - pg_tracing |
| Date: | 2023-07-25 10:16:11 |
| Message-ID: | CAJ7c6TPgfrXjK3iu1Q2bg7uZ5=k5rQsuhORGbnUE1Eqt+cOfqw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Anthonin,
> I have a working prototype of a pg_tracing extension and wanted some feedback on the design and architecture.
The patch looks very interesting, thanks for working on it and for
sharing. The facts that the patch doesn't change the core except for
two lines in instrument.{c.h} and that is uses pull-based model:
> - Collect the spans through a new pg_tracing_spans() function output
... IMO were the right design decisions. The patch lacks the
documentation, but this is OK for a PoC.
I added the patch to the nearest CF [1]. Let's see what the rest of
the community thinks.
[1] https://commitfest.postgresql.org/44/4456/
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-07-25 10:20:19 | Re: logical decoding and replication of sequences, take 2 |
| Previous Message | Anthonin Bonnefoy | 2023-07-25 09:21:55 | POC: Extension for adding distributed tracing - pg_tracing |