| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Ants Aasma <ants(dot)aasma(at)cybertec(dot)at>, Noah Misch <noah(at)leadboat(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Potential ABI breakage in upcoming minor releases |
| Date: | 2024-11-14 15:53:01 |
| Message-ID: | CAJ7c6TPage6-mV-MG9Gbsy57m3dUjKM7o060CeU+dkKdxg+Zsw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> To add to this list, Christoph Berg confirmed that timescaledb test suite crashes. [1]
Yes changing ResultRelInfo most definetely breaks TimescaleDB. The
extension uses makeNode(ResultRelInfo) and this can't end-up well:
```
static inline Node *
newNode(size_t size, NodeTag tag)
{
Node *result;
Assert(size >= sizeof(Node)); /* need the tag, at least */
result = (Node *) palloc0(size);
result->type = tag;
return result;
}
#define makeNode(_type_) ((_type_ *) newNode(sizeof(_type_),T_##_type_))
```
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2024-11-14 15:54:54 | Re: 039_end_of_wal: error in "xl_tot_len zero" test |
| Previous Message | Emre Hasegeli | 2024-11-14 15:51:51 | Object identifier types in logical replication binary mode |