| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Add const to values and nulls arguments |
| Date: | 2023-10-06 14:51:59 |
| Message-ID: | CAJ7c6TPaf-uoiTnHeYfubBVQmybpxgotLAyqiK=O7E64PhHd9Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> There are a lot of Datum *values, bool *nulls argument pairs that should
> really be const. The 0001 patch makes those changes. Some of these
> hunks depend on each other.
>
> The 0002 patch, which I'm not proposing to commit at this time, makes
> similar changes but in a way that breaks the table and index AM APIs.
> So I'm just including that here in case anyone wonders, why didn't you
> touch those. And also maybe if we ever change that API incompatibly we
> could throw this one in then.
0001 looks good to me and passes the tests in several environments,
not surprisingly. Let's merge it.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2023-10-06 15:00:57 | Re: pg16: invalid page/page verification failed |
| Previous Message | Tom Lane | 2023-10-06 14:21:38 | Re: Two Window aggregate node for logically same over clause |