Re: Remove an obsolete comment in gistinsert()

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Tender Wang <tndrwang(at)gmail(dot)com>
Subject: Re: Remove an obsolete comment in gistinsert()
Date: 2024-11-05 14:08:20
Message-ID: CAJ7c6TPXjq-Px+f+wpDU+JDf=fzE+bJ6n0G0AYdD8YNQk+kWnQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Tender,

> While learning the GIST codes, I find an obsolete comment in gistinsert ().
>
> itup = gistFormTuple(giststate, r,
> values, isnull, true /* size is currently bogus */ );

Thanks for reporting. I agree that this is an oversight of commit 1f7ef54.

The commit changed the signature of gistFormTuple():

```
IndexTuple
gistFormTuple(GISTSTATE *giststate, Relation r,
- Datum attdata[], int datumsize[], bool isnull[])
+ Datum attdata[], bool isnull[], bool newValues)
```

... but left the comment for the `datumsize` argument:

```
itup = gistFormTuple(&buildstate->giststate, index,
- values, NULL /* size is currently bogus */, isnull);
+ values, isnull, true /* size is currently bogus */);
```

I checked the rest of gistFormTuple() calls and also looked for other
comments like this. There seems to be only one call like this to fix.

--
Best regards,
Aleksander Alekseev

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey M. Borodin 2024-11-05 14:11:07 Re: MultiXact\SLRU buffers configuration
Previous Message Jan Wieck 2024-11-05 13:58:36 Re: Commit Timestamp and LSN Inversion issue