| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: gcc 13 warnings |
| Date: | 2024-07-15 08:38:42 |
| Message-ID: | CAJ7c6TPQXBVb0DJRG5ANEq6T37vCmtqm5=uDx52+7Jvf9+un+w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> /*
> * Prevent spurious warning due to compiler not realizing
> * VARATT_IS_EXTERNAL_NON_EXPANDED() branch in assign_simple_var() isn't
> * reachable due to "found" being byvalue.
> */
> if (var->datatype->typlen != 1)
> pg_unreachable();
>
> I'm somewhat inclined to think it'd be worth adding something along those
> lines to avoid this warning ([1]).
IMO we shouldn't allow warnings to appear in release builds, even
harmless ones. Otherwise we start ignoring them and will skip
something important one day. So I think we should do this.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rafia Sabih | 2024-07-15 09:50:39 | Re: Things I don't like about \du's "Attributes" column |
| Previous Message | Sutou Kouhei | 2024-07-15 08:38:22 | Re: Wrong results with grouping sets |