Re: pg_resetwal tests, logging, and docs update

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: pg_resetwal tests, logging, and docs update
Date: 2023-10-30 11:55:12
Message-ID: CAJ7c6TPL0kDwoDwcgChZTce+P_68mzVg_-viBrc7bCQyP5jwuw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> Here are updated versions of the remaining patches. I took out the
> "FIXME" notes about the multipliers applying to the -c option and
> replaced them by gentler comments. I don't intend to resolve those
> issues here.

The patch LGTM. However, postgresql:pg_resetwal test suite doesn't
pass on Windows according to cfbot. Seems to be a matter of picking a
more generic regular expression:

```
at C:/cirrus/src/bin/pg_resetwal/t/001_basic.pl line 54.
'pg_resetwal: error: could not change directory to
"foo": No such file or directory
doesn't match '(?^:error: could not read permissions of directory)'
```

Should we simply use something like:

```
qr/error: could not (read|change).* directory/
```

... instead?

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Anton A. Melnikov 2023-10-30 12:28:53 Re: Some performance degradation in REL_16 vs REL_15
Previous Message Amit Kapila 2023-10-30 11:47:36 Re: Open a streamed block for transactional messages during decoding