| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Japin Li <japinli(at)hotmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |
| Date: | 2024-07-12 09:44:54 |
| Message-ID: | CAJ7c6TPGYD=neghnRyJn__YR53g40ZdU+xoHxp0QUH6wtN9ZvQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> A comment about v3-0001.
>
> - * If true, use long segment filenames formed from lower 48 bits of the
> - * segment number, e.g. pg_xact/000000001234. Otherwise, use short
> - * filenames formed from lower 16 bits of the segment number e.g.
> - * pg_xact/1234.
> + * If true, use long segment filenames. Use short filenames otherwise.
> + * See SlruFileName().
>
> We're losing some details here even if SlruFileName() has some
> explanations, because one would need to read through the snprintf's
> 04X to know that short file names include 4 characters. I'm OK to
> mention SlruFileName() rather than duplicate the knowledge here, but
> SlruFileName() should also be updated to mention the same level of
> details with some examples of file names.
Fair enough. Here is the updated patchset.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Refactor-the-comments-about-formatting-SLRU-segme.patch | application/x-patch | 2.8 KB |
| v4-0002-Use-int64-for-page-numbers-in-clog.c-async.c.patch | application/x-patch | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2024-07-12 10:01:11 | Re: Missed opportunity for bsearch() in TransactionIdIsCurrentTransactionId()? |
| Previous Message | Alvaro Herrera | 2024-07-12 09:39:54 | Re: Restart pg_usleep when interrupted |