From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Commitfest 2023-09 starts soon |
Date: | 2023-09-04 14:36:02 |
Message-ID: | CAJ7c6TOxY+2_-dPbpHp4H+GSYOCaamPPAEH0Bkhrca8Nmqg8Tw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Peter,
> The patch was first set to "Ready for Committer" on 2023-03-29, and if I
> pull up the thread in the web archive view, that is in the middle of the
> page. So as a committer, I would expect that someone would review
> whatever happened in the second half of that thread before turning it
> over to committer.
>
> As a general rule, if significant additional discussion or patch posting
> happens after a patch is set to "Ready for Committer", I'm setting it
> back to "Needs review" until someone actually re-reviews it.
OK, fair enough.
> I also notice that you are listed as both author and reviewer of that
> patch, which I think shouldn't be done. It appears that you are in fact
> the author, so I would recommend that you remove yourself from the
> reviewers.
Sometimes I start as a reviewer and then for instance add my own
patches to the thread. In cases like this I end up being both an
author and a reviewer, but it doesn't mean that I review my own
patches :)
In this particular case IMO it would be appropriate to remove myself
from the list of reviewers. So I did.
Thanks!
--
Best regards,
Aleksander Alekseev
From | Date | Subject | |
---|---|---|---|
Next Message | Aleksander Alekseev | 2023-09-04 14:41:43 | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |
Previous Message | Andy Fan | 2023-09-04 14:35:16 | Re: Extract numeric filed in JSONB more effectively |