| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Sergey Dudoladov <sergey(dot)dudoladov(at)gmail(dot)com>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com> |
| Subject: | Re: Add connection active, idle time to pg_stat_activity |
| Date: | 2022-07-22 09:42:20 |
| Message-ID: | CAJ7c6TOVMem+u7W3As5vCQy_oZLkijXBDZKdL1EFdiTWf9kV8A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
All in all the patch seems to be in good shape.
> This is consistent with the current documentation:
>
> > Each individual server process transmits new statistical counts to the collector just before going idle; so a query or transaction still in progress does not affect the displayed totals.
>
> But it makes me wonder if there will be a lot of use of total_idle_in_transaction_time and if the patch should actually alter this behavior.
>
> Thoughts?
On second thought, this is arguably out of scope of this particular
patch and this particular discussion. In any case, having some stats
is better than none.
I'm going to change the status of the patch to "Ready for Committer"
in a short time unless anyone has a second opinion.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-07-22 10:06:21 | Re: PANIC: wrong buffer passed to visibilitymap_clear |
| Previous Message | Richard Guo | 2022-07-22 09:33:24 | Re: Add proper planner support for ORDER BY / DISTINCT aggregates |