Re: pgsql: psql: add an optional execution-count limit to \watch.

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Cc: Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pgsql: psql: add an optional execution-count limit to \watch.
Date: 2023-04-10 12:48:57
Message-ID: CAJ7c6TO9KpYYxoVVseWEQB5KtjWDkt8NfyAeKPcHoe2Jq+ykpw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

> I wonder if we can setup as least some buildfarm members to exercise
> TAP tests on non-C locales.
>
> > > The proposed fix is attached.
> >
> > LGTM, will push in a bit (unless you want to?)
>
> Please push.

The test still fails under the following conditions:

```
$ env | grep UTF-8
LC_ADDRESS=ru_RU.UTF-8
LC_NAME=ru_RU.UTF-8
LC_MONETARY=ru_RU.UTF-8
LC_PAPER=ru_RU.UTF-8
LANG=en_US.UTF-8
LC_IDENTIFICATION=ru_RU.UTF-8
LC_TELEPHONE=ru_RU.UTF-8
LC_MEASUREMENT=ru_RU.UTF-8
LC_CTYPE=en_US.UTF-8
LC_TIME=ru_RU.UTF-8
LC_ALL=en_US.UTF-8
LC_NUMERIC=ru_RU.UTF-8
```

This is up-to-dated Ubuntu 22.04 with pretty much default settings
except for the timezone changed to MSK and enabled Russian keyboard
layout.

Here is a proposed fix. I realize this is a somewhat suboptimal
solution, but it makes the test pass regardless of the locale
settings.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
fix.diff application/octet-stream 427 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-04-10 13:54:42 Re: pgsql: psql: add an optional execution-count limit to \watch.
Previous Message Daniel Gustafsson 2023-04-08 21:38:48 pgsql: Simplify version check for SKIP clause

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-04-10 13:54:42 Re: pgsql: psql: add an optional execution-count limit to \watch.
Previous Message Ashutosh Bapat 2023-04-10 11:25:58 Re: Unnecessary confirm work on logical replication