Re: [PATCH] Check more invariants during syscache initialization

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Zhang Mingli <zmlpostgres(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: [PATCH] Check more invariants during syscache initialization
Date: 2023-07-26 13:59:31
Message-ID: CAJ7c6TO72KrW7VrzYKBJumCPzUeBAiRTo-+9ro3Wrjpe+Z1-ZQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Zhang,

> That remind me to have a look other codes, and a grep search `oid != 0` show there are several files using old != 0.
>
> ```
> .//src/bin/pg_resetwal/pg_resetwal.c: if (set_oid != 0)
> .//src/bin/pg_resetwal/pg_resetwal.c: if (set_oid != 0)
> .//src/bin/pg_dump/pg_backup_tar.c: if (oid != 0)
> .//src/bin/pg_dump/pg_backup_custom.c: while (oid != 0)
> .//src/bin/pg_dump/pg_backup_custom.c: while (oid != 0)
> ```
> That is another story…I would like provide a patch if it worths.

Good catch. Please do so.

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2023-07-26 14:06:53 Re: cataloguing NOT NULL constraints
Previous Message Alvaro Herrera 2023-07-26 13:57:03 Re: WaitForOlderSnapshots in DETACH PARTITION causes deadlocks