Re: [PATCH] Rename trim_array() for consistency with the rest of array_* functions

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Vik Fearing <vik(at)postgresfriends(dot)org>
Subject: Re: [PATCH] Rename trim_array() for consistency with the rest of array_* functions
Date: 2024-11-04 10:36:25
Message-ID: CAJ7c6TO6D9wBYd50HXO2XvGzeRWoBR32Uu7MEz_G2+suHmtGkQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Michael,

> On Tue, Oct 29, 2024 at 03:23:15PM +0300, Aleksander Alekseev wrote:
> >> While unfortunately named, we cannot deprecate TRIM_ARRAY() because it
> >> is mandated by the standard.
> >
> > I didn't know that, thanks.
>
> Wow. Neither did I.
>
> > Still PostgreSQL doesn't follow the standard precisely in more than
> > one respect. Perhaps we should add array_trim() and keep both? Or
> > (less likely) remove trim_array() and document this deviation from the
> > standard? Or at least document why it's named this way.
>
> I suspect that it is not the only function in this case, and that we
> don't document that it is in the standard. I would suggest to let
> things the way they are on HEAD and withdraw the patch.

Thanks for your feedback. The patch is withdrawn.

--
Best regards,
Aleksander Alekseev

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2024-11-04 10:54:47 Re: Pgoutput not capturing the generated columns
Previous Message Matthias van de Meent 2024-11-04 10:08:03 Re: protocol-level wait-for-LSN