| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: Avoid use deprecated Windows Memory API |
| Date: | 2022-09-15 13:19:26 |
| Message-ID: | CAJ7c6TO3JSH5aSqnwFHsQUkHs7pmFsQ5poo0hkaqstS7B=eaGg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Alvaro,
> In what way is this code cleaner? I argue it is the opposite.
Well, I guess it depends on the perspective. There are a bit more
lines of code for sure. So if "less code is better" is the criteria,
then no, the new code is not cleaner. If the criteria is to use an API
according to the spec provided by the vendor, to me personally the new
code looks cleaner.
This being said I don't have a strong opinion on whether this patch
should be accepted or not. I completely agree that MS will actually
keep LocalAlloc() indefinitely for backward compatibility with
existing applications, as the company always did.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2022-09-15 13:29:22 | Re: Avoid use deprecated Windows Memory API |
| Previous Message | Alvaro Herrera | 2022-09-15 13:13:47 | Re: Avoid use deprecated Windows Memory API |