Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests
Date: 2023-04-13 10:35:26
Message-ID: CAJ7c6TO00YK0NyEc3Q0KHnib+OqVjZue8cq5AfYHgB1Wyovb6Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> On Wed, Apr 12, 2023 at 03:30:03PM +0300, Aleksander Alekseev wrote:
> > Any objections if we remove the tests for "user"?
>
> Based on some rather-recent experience in this area with
> COERCE_SQL_SYNTAX, the relationship between the SQL keywords and the
> way they can handled internally could be tricky if this area of the
> code is touched. So I would choose to keep these tests, FWIW.

Thanks for the feedback. I see this is a controversial topic so in the
interest of saving our time I'm withdrawing the patch.

--
Best regards,
Aleksander Alekseev

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii.Yuki@df.MitsubishiElectric.co.jp 2023-04-13 10:56:26 RE: Partial aggregates pushdown
Previous Message Julien Rouhaud 2023-04-13 10:04:19 Re: pg_upgrade and logical replication