Re: Add arbitrary xid and mxid to pg_resetwal

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: Daniil Davydov <3danissimo(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add arbitrary xid and mxid to pg_resetwal
Date: 2025-03-07 14:35:04
Message-ID: CAJ7c6TO-EMTRMnuZmhqDHusYnE_y+wQ7oADF2k0UBnozk7rQfg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Daniil,

Thanks for the patch.

> main idea of this patch (for REL_17_STABLE)

Your patch should target the `master` branch. Also please add a
corresponding entry to the nearest open commitfest [1].

> In my opinion, this will be useful primarily to simplify testing, since at the moment you have to create segments manually (as in this article).

In this case you should add a test or two that demonstrate this. As
separate commits perhaps.

If you could also demonstrate that these tests improve code coverage
for instance that would be great.

[1]: https://commitfest.postgresql.org/

--
Best regards,
Aleksander Alekseev

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Sabino Mullane 2025-03-07 14:36:58 Re: what's going on with lapwing?
Previous Message Julien Rouhaud 2025-03-07 14:34:05 Re: what's going on with lapwing?