From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Cc: | Mats Kindahl <mats(at)timescale(dot)com> |
Subject: | Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery |
Date: | 2024-03-04 12:41:16 |
Message-ID: | CAJ7c6TNumEgVKmR+b=r5cfB3pAdxq9eF4+B9QbtCri9tzC5T4Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
> I wanted to hook into the EXPLAIN output for queries and add some extra information, but since there is no standard_ExplainOneQuery() I had to copy the code and create my own version.
>
> Since the pattern with other hooks for a function WhateverFunction() seems to be that there is a standard_WhateverFunction() for each WhateverFunction_hook, I created a patch to follow this pattern for your consideration.
>
> I was also considering adding a callback so that you can annotate any node with explanatory information that is not a custom scan node. This could be used to propagate and summarize information from custom scan nodes, but I had no immediate use for that so did not add it here. I would still be interested in hearing if you think this is something that would be useful to the community.
Thanks for the patch. LGTM.
I registered the patch on the nearest open CF [1] and marked it as
RfC. It is a pretty straightforward refactoring.
[1]: https://commitfest.postgresql.org/48/4879/
--
Best regards,
Aleksander Alekseev
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2024-03-04 12:50:32 | Re: abi-compliance-checker |
Previous Message | Aleksander Alekseev | 2024-03-04 12:34:20 | Re: Dump-restore loosing 'attnotnull' bit for DEFERRABLE PRIMARY KEY column(s). |