| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Mikhail Gribkov <youzhick(at)gmail(dot)com> |
| Subject: | Re: Avoid race condition for event_triggers regress test |
| Date: | 2023-10-19 14:01:28 |
| Message-ID: | CAJ7c6TNbHN0TE7cx-pTfMZxmjBL9bAjorz2S9QoCJoeQ2ALsUg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> The current problem is that a race condition may occur on some systems, when oidjoins test starts a moment later than normally and affects logins count for on-login trigger test. The problem is quite a rare one and I only faced it once. But rare or not - the problem is a problem and it should be addressed.
Thanks for the patch and the steps to reproduce.
I tested the patch and it does what is claimed. Including the steps to
reproduce as a separate patch with .txt extension so cfbot will ignore
it.
I think it's a good find and a good fix.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| reproduce.txt | text/plain | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-10-19 14:24:41 | Re: The danger of deleting backup_label |
| Previous Message | shihao zhong | 2023-10-19 13:58:05 | Re: Allow ALTER SYSTEM SET on unrecognized custom GUCs |