| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Hugo Zhang <hugo(dot)zhang(at)openpie(dot)com> |
| Subject: | Re: Useless parameter 'cur_skey' in IndexScanOK |
| Date: | 2024-07-03 13:41:21 |
| Message-ID: | CAJ7c6TNWJUp1-B_hQsg3_ie4r5eXOXdgtyN-4U4AjRcrcg4RvQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> The 'cur_skey' parameter in `IndexScanOK` funciton doesn't seem to be useful.
Good catch. As I understand it is not used for anything since
a78fcfb51243 (dated 2006) and this is a static function, so we
shouldn't worry about third-party extensions.
I wonder why none of the compilers complained about this.
Here is the patch.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-IndexScanOK-remove-unused-parameter-cur_skey.patch | application/x-patch | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-07-03 13:42:33 | Re: pg_wal_summary_contents() and pg_walsummary may return different results on the same WAL summary file |
| Previous Message | Andres Freund | 2024-07-03 13:25:25 | Re: CI, macports, darwin version problems |