| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Hugo Zhang <hugo(dot)zhang(at)openpie(dot)com> |
| Subject: | Re: Useless parameter 'cur_skey' in IndexScanOK |
| Date: | 2024-07-03 13:46:56 |
| Message-ID: | 603E44BD-A1F3-493C-A904-57170A6DF257@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 3 Jul 2024, at 15:41, Aleksander Alekseev <aleksander(at)timescale(dot)com> wrote:
>> The 'cur_skey' parameter in `IndexScanOK` funciton doesn't seem to be useful.
> Good catch. As I understand it is not used for anything since
> a78fcfb51243 (dated 2006) and this is a static function, so we
> shouldn't worry about third-party extensions.
Agreed, it seems reasonable to clean this up.
> I wonder why none of the compilers complained about this.
Not to mention static analyzers.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2024-07-03 13:48:58 | Re: Optimize numeric multiplication for one and two base-NBASE digit multiplicands. |
| Previous Message | Robert Haas | 2024-07-03 13:42:33 | Re: pg_wal_summary_contents() and pg_walsummary may return different results on the same WAL summary file |