| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Sven Klemm <sven(at)timescale(dot)com> |
| Subject: | Re: [PATCH] Fix memory corruption in pg_shdepend.c |
| Date: | 2021-10-22 07:48:57 |
| Message-ID: | CAJ7c6TN5AwbGXXm0qS4yBfzJnaY6_OHPCJ_ZCy-C6yP2T_7j=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Tom,
> BTW, I think there is an additional bug in copyTemplateDependencies:
> I do not see it initializing slot->tts_isnull[] anywhere. It
> probably accidentally works (at least in devel builds) because we zero
> that memory somewhere else, but surely this code shouldn't assume that?
tts_isnull[] is zeroed in:
- copyTemplateDependencies
-- MakeSingleTupleTableSlot, which simply wraps:
--- MakeTupleTableSlot
... where the slot is allocated with palloc0. The assumption that
MakeSingleTupleTableSlot() returns valid TupleTableSlot* with zeroed
tts_isnull[] seems reasonable, no?
What confuses me is the fact that we have two procedures that do the
same thing. Maybe one is redundant.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rafia Sabih | 2021-10-22 08:22:54 | Add connection active, idle time to pg_stat_activity |
| Previous Message | Masahiko Sawada | 2021-10-22 07:32:27 | Re: Added schema level support for publication. |