Re: Add common function ReplicationOriginName.

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add common function ReplicationOriginName.
Date: 2022-09-19 08:57:09
Message-ID: CAJ7c6TMVjmNmqqGkYM2uwdFnZUAf39ViSS+P3WxccB5BZ4VAVw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Peter,

> PSA a patch to add a common function ReplicationOriginName

The patch looks good to me.

One nitpick I have is that the 2nd argument of snprintf is size_t
while we are passing int's. Your patch is consistent with the current
implementation of ReplicationOriginNameForTablesync() and similar
functions in tablesync.c. However I would like to mention this in case
the committer will be interested in replacing ints with Size's while
on it.

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2022-09-19 08:57:18 Re: Patch to address creation of PgStat* contexts with null parent context
Previous Message Алена Рыбакина 2022-09-19 08:47:21 Re: RFC: Logging plan of the running query