| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Jelte Fennema <postgres(at)jeltef(dot)nl>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Jacob Champion <jchampion(at)timescale(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, Michael Banck <mbanck(at)gmx(dot)net>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: [EXTERNAL] Support load balancing in libpq |
| Date: | 2023-03-27 13:35:50 |
| Message-ID: | CAJ7c6TMKiOJAjEqGeGQ9ntZijM=OgAQwPXnh0NnT0cse1-oBEw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> ```
> + ret = store_conn_addrinfo(conn, addrlist);
> + pg_freeaddrinfo_all(hint.ai_family, addrlist);
> + if (ret)
> + goto error_return; /* message already logged */
> ```
> The goto path is not test-covered.
D'oh, this one is fine since store_conn_addrinfo() is going to fail
only when we are out of memory.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2023-03-27 13:42:35 | Re: Infinite Interval |
| Previous Message | Aleksander Alekseev | 2023-03-27 13:32:20 | Re: [EXTERNAL] Support load balancing in libpq |