| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: meson "experimental"? |
| Date: | 2024-05-30 10:32:18 |
| Message-ID: | CAJ7c6TM7ct0EjoCQaLSVYoxxnEw4xCUFebWj77GktWsqEdyCtQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> > [*] What is the correct name for this?
>
> I believe in this section it should be "Visual Studio" as we specify
> elsewhere [1][2]. In [2] we name specific required versions. Maybe we
> should reference this section.
>
> While on it, in [2] section 17.7.5 is named "Visual". I don't think
> such a product exists and find it confusing. Maybe we should rename
> the section to "Visual Studio".
Here are corresponding patches.
> Also I don't see any mention of the minimum required version of Ninja.
> I think we should add it too, or maybe reference the corresponding
> section I couldn't find in "17.1 Requirements"
>
> [1]: https://www.postgresql.org/docs/devel/install-meson.html
> [2]: https://www.postgresql.org/docs/devel/installation-platform-notes.html
By a quick look on the buildfarm we seem to use Ninja >= 1.11.1.
However since Meson can use both Ninja and VS as a backend I'm not
certain which section would be most appropriate for naming the minimal
required version of Ninja.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Meson-is-not-experimental-on-Windows.patch | application/octet-stream | 1.3 KB |
| v1-0002-Rename-section-17.7.5-to-Visual-Studio.patch | application/octet-stream | 871 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2024-05-30 12:26:18 | Re: Implementing CustomScan over an index |
| Previous Message | Aleksander Alekseev | 2024-05-30 10:07:02 | Re: meson "experimental"? |