Re: Cleanup: PGProc->links doesn't need to be the first field anymore

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Re: Cleanup: PGProc->links doesn't need to be the first field anymore
Date: 2024-07-04 12:09:15
Message-ID: CAJ7c6TM=oMPS1WD8c4J9Dqn3Za7baZsz8-g9GNdSSea5_uJXQA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Heikki,

> I tried moving it and ran the regression tests. That revealed one place
> where we still don't use dlist_container:
>
> > if (!dlist_is_empty(procgloballist))
> > {
> > MyProc = (PGPROC *) dlist_pop_head_node(procgloballist);
> > ...
>
> I believe that was just an oversight. Trivial patch attached.

I tested your patch. LGTM.

PGPROC is exposed to third-party code, but since we don't change the
structure this time, the extensions will not be affected.

--
Best regards,
Aleksander Alekseev

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dagfinn Ilmari Mannsåker 2024-07-04 12:13:19 Re: Unknown annotation '-cim' in source code
Previous Message Amit Kapila 2024-07-04 12:07:10 Re: Conflict Detection and Resolution