| From: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Asim R P <apraveen(at)pivotal(dot)io>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Subject: | Re: Pluggable Storage - Andres's take |
| Date: | 2019-01-22 10:31:58 |
| Message-ID: | CAJ3gD9e7BQFLnBUU1B763m1Vt38sn76JCCKW+_-tSqxwGeJ03g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 22 Jan 2019 at 15:29, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:
> > On Mon, Jan 21, 2019 at 9:33 AM Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
> >
> > Regression tests that use \d+ to show the table details might
> > not be interested specifically in table access method. But these will
> > fail if run with a modified default access method.
>
> I see your point, but if a test is not interested specifically in a table am,
> then I guess it wouldn't use a custom table am in the first place, right?
Right. It wouldn't use a custom table am. But I mean, despite not
using a custom table am, the test would fail if the regression runs
with a changed default access method, because the regression output
file has only one particular am value output.
> Anyway, I don't have strong opinion here, so if everyone agrees that HIDE_TABLEAM
> will show/hide access method unconditionally, I'm fine with that.
Yeah, I agree it's subjective.
--
Thanks,
-Amit Khandekar
EnterpriseDB Corporation
The Postgres Database Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2019-01-22 11:04:36 | Rare SSL failures on eelpout |
| Previous Message | Fabien COELHO | 2019-01-22 10:31:46 | Re: [PATCH] pgbench tap tests fail if the path contains a perl special character |