Re: cross-platform pg_basebackup

Hi,
Patch v2 looks good to me, I have tested it, and pg_basebackup works fine
across the platforms (Windows to Linux and Linux to Windows).
Syntax used for testing
$ pg_basebackup -h remote_server_ip -p 5432 -U user_name -D backup/data -T
olddir=newdir

I have also tested with non-absolute paths, it behaves as expected.

On Fri, Oct 21, 2022 at 12:42 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:

>
> On 2022-10-20 Th 14:47, Robert Haas wrote:
> > On Thu, Oct 20, 2022 at 1:28 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> >>> Cool. Here's a patch.
> >> LGTM, except I'd be inclined to ensure that all the macros
> >> are function-style, ie
> >>
> >> +#define IS_DIR_SEP(ch) IS_NONWINDOWS_DIR_SEP(ch)
> >>
> >> not just
> >>
> >> +#define IS_DIR_SEP IS_NONWINDOWS_DIR_SEP
> >>
> >> I don't recall the exact rules, but I know that the second style
> >> can lead to expanding the macro in more cases, which we likely
> >> don't want. It also seems like better documentation to show
> >> the expected arguments.
> > OK, thanks. v2 attached.
> >
>
>
> Looks good.
>
>
> cheers
>
>
> andrew
>
> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com
>
>
>
>

--
Regards,
Davinder
EnterpriseDB: http://www.enterprisedb.com