From: | Merlin Moncure <mmoncure(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com> |
Subject: | Re: tracking commit timestamps |
Date: | 2014-11-03 23:16:08 |
Message-ID: | CAHyXU0xg7vDAEo3RR0-4D8W6mGCwV-fpgvtrQcsKJvi5rs0TfA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-www |
On Mon, Nov 3, 2014 at 3:26 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On 11/1/14 8:04 AM, Petr Jelinek wrote:
>> On second thought, maybe those should be pg_get_transaction_committs,
>> pg_get_transaction_committs_data, etc.
>
> Please don't name anything "committs". That looks like a misspelling of
> something.
>
> There is nothing wrong with
>
> pg_get_transaction_commit_timestamp()
>
> If you want to reduce the length, lose the "get".
+1: all non void returning functions 'get' something.
>> For me the commit time thing feels problematic in the way I perceive it
>> - I see commit time as a point in time, where I see commit timestamp (or
>> committs for short) as something that can recorded. So I would prefer to
>> stick with commit timestamp/committs.
>
> In PostgreSQL, it is pretty clearly established that time is hours,
> minutes, seconds, and timestamp is years, months, days, hours, minutes,
> seconds. So unless this feature only records the hour, minute, and
> second of a commit, it should be "timestamp".
Elsewhere, for example, we have: "pg_last_xact_replay_timestamp()".
So, in keeping with that, maybe,
pg_xact_commit_timestamp(xid)
merlin
From | Date | Subject | |
---|---|---|---|
Next Message | Álvaro Hernández Tortosa | 2014-11-03 23:31:43 | Re: Repeatable read and serializable transactions see data committed after tx start |
Previous Message | Kevin Grittner | 2014-11-03 22:56:11 | Re: Let's drop two obsolete features which are bear-traps for novices |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-11-04 08:05:21 | Re: tracking commit timestamps |
Previous Message | Petr Jelinek | 2014-11-03 22:17:38 | Re: tracking commit timestamps |