From: | Merlin Moncure <mmoncure(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: fix for readline terminal size problems when window is resized with open pager |
Date: | 2015-12-16 19:38:08 |
Message-ID: | CAHyXU0xRJPtisgwf51EXwt=kGs3U21+scm-HXwsSzLgT0QQmYg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Dec 16, 2015 at 1:29 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I did some more experimentation and concluded that actually, this problem
> has nothing whatsoever to do with pager invocations. What seems to really
> be happening is that libreadline activates its SIGWINCH handler only while
> it's being called to collect input, which is fine in itself, but *it does
> not notice screen resizes that happen when the handler is not active*.
>
> You can prove this by doing, say, "select pg_sleep(10);" and resizing
> the window before the backend comes back. Readline never notices the
> resize, even though no pager invocation happens at all.
>
> So I now think that print.c shouldn't be involved at all, and the right
> thing to do is just have gets_interactive() invoke the resize function
> immediately before calling readline(). That will still leave a window
> for SIGWINCH to be missed, but it's a pretty tiny one.
right -- agreed.
> And somebody oughta report this as a libreadline bug ...
See https://bugs.python.org/issue23735 for background. Apparently
this is expected behavior (and we are far from the only ones
complaining about it):
"And so we reach where we are. If a SIGWINCH arrives while readline is
not active, and the application using callback mode does not catch it and
tell readline about the updated screen dimensions (rl_set_screen_size()
exists for this purpose), readline will not know about the new size."
merlin
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2015-12-16 19:39:58 | Re: On-demand running query plans using auto_explain and signals |
Previous Message | Tom Lane | 2015-12-16 19:29:26 | Re: fix for readline terminal size problems when window is resized with open pager |