Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility.

From: Shubham Khanna <khannashubham1197(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility.
Date: 2025-02-17 18:45:57
Message-ID: CAHv8RjJsfvLT0nfwXF0Qz67MYQr7DFSJfaGdG25zpOokVfDE7Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 17, 2025 at 9:43 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Wed, 22 Jan 2025 at 16:23, Shubham Khanna
> <khannashubham1197(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > Following the recent comments on Patch v13-0001, the patch was not
> > applied to the HEAD. I have addressed the feedback and prepared a
> > rebased version to incorporate the necessary adjustments.
> > Please find the updated patch.
>
> The patch needs to be rebased:
> git am v14-0001-Add-support-for-two-phase-commit-in-pg_createsub.patch
> Applying: Add support for two-phase commit in pg_createsubscriber
> error: patch failed: src/bin/pg_basebackup/pg_createsubscriber.c:1326
> error: src/bin/pg_basebackup/pg_createsubscriber.c: patch does not apply
>

I have addressed the feedback and prepared a rebased version to
incorporate the necessary adjustments.
Please find the updated patch.

Thanks and regards,
Shubham Khanna.

Attachment Content-Type Size
v15-0001-Add-support-for-two-phase-commit-in-pg_createsub.patch application/octet-stream 14.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ilia Evdokimov 2025-02-17 18:53:16 Re: explain analyze rows=%.0f
Previous Message David G. Johnston 2025-02-17 18:43:04 Re: Clarification on Role Access Rights to Table Indexes