| From: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |
| Date: | 2025-03-20 04:15:09 |
| Message-ID: | CAHv8RjJiPK0sWDgPTaL34aPTNh-U4t_6eudtdTsomHZ0HnyjMg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 20, 2025 at 9:37 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Thu, 20 Mar 2025 at 09:06, Shubham Khanna
> <khannashubham1197(at)gmail(dot)com> wrote:
> >
> > The attached patch contains the suggested changes.
>
> Couple of minor comments:
> 1) The second and third line comments can be in same line:
> +# Create user-defined publications, wait for streaming replication to sync them
> +# to the standby, then verify that '--remove'
> +# removes them.
>
Fixed.
> 2) This comment can be in a single line:
> +# In passing, also test the --enable-two-phase option and
> +# --remove option
>
Fixed.
The attached patch contains the suggested changes.
Thanks and regards,
Shubham Khanna.
| Attachment | Content-Type | Size |
|---|---|---|
| v25-0001-Support-for-dropping-all-publications-in-pg_crea.patch | application/octet-stream | 12.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubham Khanna | 2025-03-20 04:55:11 | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |
| Previous Message | vignesh C | 2025-03-20 04:07:04 | Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |