| From: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility. |
| Date: | 2025-01-20 07:00:26 |
| Message-ID: | CAHv8RjJ=RfagawQbik2yJ+gmAOmZTsGH8NYQUGK4pG6ORVF7uw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 20, 2025 at 12:00 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Shubham,
>
> Patch v12-0001 LGTM.
>
> BTW, there is a precedent for passing the 'opt' arg but then only
> using one member from it. See function wait_for_end_recovery in this
> same file. So whether you decide to change the code per Shlok's review
> [1], or decide not to change it -- either way is OK for me.
>
> ======
> [1] https://www.postgresql.org/message-id/CANhcyEXQ1h%3DoSPFFziCZuU6far6a82DQafL0S85CyVRyEntA%2Bw%40mail.gmail.com
>
I have incorporated Shlok's suggestion [1] into the patch and made the
necessary updates.
The attached v13 patch at [2] contains the updated changes.
[1] https://www.postgresql.org/message-id/CANhcyEXQ1h%3DoSPFFziCZuU6far6a82DQafL0S85CyVRyEntA%2Bw%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAHv8RjJfaHFMeDkHOdMpLUHCeDN%2Be5p0CsdQxcKEOiWRnRjxfg%40mail.gmail.com
Thanks and regards,
Shubham Khanna.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Guillaume Lelarge | 2025-01-20 07:24:54 | Re: improve DEBUG1 logging of parallel workers for CREATE INDEX? |
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-01-20 06:53:39 | RE: Conflict detection for update_deleted in logical replication |