Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size

On Mon, Jan 6, 2025 at 3:22 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Shubham.
>
> The patch v6-0001 LGTM.
>
> OTOH, if you want to be picky, the docs wording could be slightly
> modified to be more consistent with the coded warning message.
>
> CURRENT
> Replication failures can occur if required WAL files are prematurely
> deleted. To prevent this, the source server must set <xref
> linkend="guc-max-slot-wal-keep-size"/> to <literal>-1</literal>,
> ensuring WAL files are not automatically removed.
>
> SUGGESTION
> Replication failures can occur if required WAL files are missing. To
> prevent this, the source server must set <xref
> linkend="guc-max-slot-wal-keep-size"/> to <literal>-1</literal> to
> ensure that required WAL files are not prematurely removed.
>
> ~~~
>
> See the attached NITPICKS diff if you want to make this change.
>

I have used your suggestion and updated the 'pg_createsubscriber'
documentation accordingly.
The attached Patch contains the suggested change.

Thanks and regards,
Shubham Khanna.