| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com> |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2024-08-07 08:00:37 |
| Message-ID: | CAHut+PvZWOYgUFCC2FFcbKoPUG65f8oz3bf90fw7CmejG60PKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Shubham,
Here are my review comments for patch v24-0001
I think the TAP tests have incorrect expected results for the nogen-to-gen case.
Whereas the HEAD code will cause "ERROR" for this test scenario, patch
0001 does not. IMO the behaviour should be unchanged for this scenario
which has no generated column on the publisher side. So it seems this
is a bug in patch 0001.
FYI, I have included "FIXME" comments in the attached top-up diff
patch to show which test cases I think are expecting wrong results.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| PS_NITPICKS_20240807_gencols_v240001.txt | text/plain | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-08-07 08:15:39 | Re: Logical Replication of sequences |
| Previous Message | Heikki Linnakangas | 2024-08-07 07:51:36 | Re: Thread-unsafe MD5 on big-endian systems with no OpenSSL |