| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: walsender.c comment with no context is hard to understand |
| Date: | 2024-06-27 23:44:38 |
| Message-ID: | CAHut+PtDwJY-ZKoj9CLDnpN+j_p0SmGYbrkSywD3gFdZZuL5fA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 27, 2024 at 3:44 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jun 26, 2024 at 02:30:26PM +0530, vignesh C wrote:
> > On Mon, 3 Jun 2024 at 11:21, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >> Perhaps the comment should say something like it used to:
> >> /* Fail if there is not enough WAL available. This can happen during
> >> shutdown. */
> >
> > Agree with this, +1 for this change.
>
> That would be an improvement. Would you like to send a patch with all
> the areas you think could stand for improvements?
> --
OK, I attached a patch equivalent of the suggestion in this thread.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-walsender-comment.patch | application/octet-stream | 920 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-06-28 00:00:00 | Re: Virtual generated columns |
| Previous Message | Peter Geoghegan | 2024-06-27 22:40:54 | Re: Improve EXPLAIN output for multicolumn B-Tree Index |