| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, christophe(dot)courtois(at)dalibo(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: pg_createsubscriber: publication-name and subscription-name options do not exist |
| Date: | 2024-12-03 03:50:43 |
| Message-ID: | CAHut+Pvh0UEmwX0=bSMy_2Jk6NM9JPS=vZTcrMkay58wF-58yA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
Hi Shubham,
Here are my comments for v4-0001.
1.
- If <option>replication-slot-name</option> is not specified, the
+ If the <option>--replication-slot-name</option> is not specified, the
No. I already said before ([1] #2) that there is no such thing called
"--replication-slot-name". It should be called "--replication-slot"
~~~
2.
FYI your v4 changes are not using the text that I had suggested in
[1]. E.g. When the switch/option term is not included I felt it was
better to omit the word "the". Maybe you changed that deliberately, in
which case that is your choice, but TBH I suspect this may have been
unintentional.
IMO it should look like this.
/If the <option>--publication</option> is not specified/If
<option>--publication</option> is not specified/
/If the <option>--replication-slot-name</option> is not specified/If
<option>--replication-slot</option> is not specified/
/If the <option>--subscription</option> is not specified/If
<option>--subscription</option> is not specified/
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubham Khanna | 2024-12-03 04:22:25 | Re: pg_createsubscriber: publication-name and subscription-name options do not exist |
| Previous Message | Shubham Khanna | 2024-12-03 03:28:16 | Re: pg_createsubscriber: publication-name and subscription-name options do not exist |