| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | Re: Slow catchup of 2PC (twophase) transactions on replica in LR |
| Date: | 2024-07-22 09:17:44 |
| Message-ID: | CAHut+PvWOt0QhjbjwGA=VLyhg092O-0BLADUp_haYJX5XJBkTg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Patch v22-0001 LGTM apart from the following nitpicks
======
src/sgml/ref/alter_subscription.sgml
nitpick - /one needs to/you need to/
======
src/backend/commands/subscriptioncmds.c
CheckAlterSubOption:
nitpick = "ideally we could have..." doesn't make sense because the
code uses a more consistent/simpler way. So other option was not ideal
after all.
AlterSubscription
nitpick - typo /syncronization/synchronization/
nipick - plural fix
======
Kind Regards,
Peter Smith.
Fujitsu Australia.
| Attachment | Content-Type | Size |
|---|---|---|
| PS_20240722_NITPICKS_2PC.txt | text/plain | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2024-07-22 09:26:28 | Re: WIP: parallel GiST index builds |
| Previous Message | shveta malik | 2024-07-22 09:03:07 | Re: Conflict detection and logging in logical replication |