| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Synchronizing slots from primary to standby |
| Date: | 2023-12-07 22:58:52 |
| Message-ID: | CAHut+PvRD5V-zzTvffDdcnqB1T4JNATKGgw+wdQCKAgeCYr0xQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi.
Here is another review comment for the patch v43-0001.
======
src/bin/pg_dump/pg_dump.c
1. getSubscriptions
+ if (fout->remoteVersion >= 170000)
+ appendPQExpBufferStr(query,
+ " subfailoverstate\n");
+ else
+ appendPQExpBuffer(query,
+ " '%c' AS subfailoverstate\n",
+ LOGICALREP_FAILOVER_STATE_DISABLED);
+
That first appended string should include the table alias same as all
the nearby code does.
e.g. " subfailoverstate\n" should be " s.subfailoverstate\n"
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-12-07 23:02:15 | Re: postgres_fdw test timeouts |
| Previous Message | Jeff Davis | 2023-12-07 22:00:15 | Re: CREATE FUNCTION ... SEARCH { DEFAULT | SYSTEM | SESSION } |