| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: pg_upgrade and logical replication |
| Date: | 2023-11-09 02:14:05 |
| Message-ID: | CAHut+PvNb3Zvoce3WmB-6ewY0ReN6aoM9X2WVwV4CRmqARnm-Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for addressing my previous review comments.
I re-checked the latest patch v12-0001 and found the following:
======
Commit message
1.
The new SQL binary_upgrade_create_sub_rel_state function has the following
syntax:
SELECT binary_upgrade_create_sub_rel_state(subname text, relid oid,
state char [,sublsn pg_lsn])
~
Looks like v12 accidentally forgot to update this to the modified
function name 'binary_upgrade_add_sub_rel_state'
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2023-11-09 02:23:01 | Re: Eager page freeze criteria clarification |
| Previous Message | Stephen Frost | 2023-11-09 02:05:44 | Re: [PATCHES] Post-special page storage TDE support |