| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | "Shinoda, Noriyoshi (SXD Japan FSI)" <noriyoshi(dot)shinoda(at)hpe(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com> |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2025-01-23 23:10:56 |
| Message-ID: | CAHut+PvEupE2peLfdaxuh1xwn4Zad-GEHd8806YKTK=EyoF4Tw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 24, 2025 at 12:03 AM Shinoda, Noriyoshi (SXD Japan FSI)
<noriyoshi(dot)shinoda(at)hpe(dot)com> wrote:
>
> Hi, hackers.
>
> Thanks for developing this great feature.
> The documentation for the pg_publication catalog shows a 'pubgencols' column, but the actual column name is the 'pubgencols_type' column.
> Also, the order of the columns in the documentation differs from the order of the columns in the actual pg_publication catalog.
> The attached patch changes the column names and order in the documentation.
>
Your catalog pg_publication docs fix patch does what it says and
looked ok to me.
However, in hindsight, I am not sure that the column should have been
renamed 'pubgencols_type' in the first place because I cannot find any
other catalogs with an underscore in their column names.
Maybe 'pubgencolstype' or simply leaving it as 'pubgencols' would have
been better?
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-01-23 23:13:26 | Re: Increase of maintenance_work_mem limit in 64-bit Windows |
| Previous Message | Masahiko Sawada | 2025-01-23 22:34:38 | Fix assert failure when decoding XLOG_PARAMETER_CHANGE on primary |