| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | Re: Single transaction in the tablesync worker? |
| Date: | 2021-01-04 09:28:30 |
| Message-ID: | CAHut+PuzPmFzk3p4oL9H3nkiY6utFryV9c5dW6kRhCe_RY=gnA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Amit.
PSA my v10 patch for the Solution1.
v10 is essentially the same as v9, except now all the temporary "!!>>"
logging has been isolated to a separate (optional) patch 0002.
====
Features:
* tablesync slot is now permanent instead of temporary. The tablesync
slot name is no longer tied to the Subscription slot na
* the tablesync slot cleanup (drop) code is added for DropSubscription
and for finish_sync_worker functions
* tablesync worked now allowing multiple tx instead of single tx
* a new state (SUBREL_STATE_COPYDONE) is persisted after a successful
copy_table in LogicalRepSyncTableStart.
* if a re-launched tablesync finds the state is SUBREL_STATE_COPYDONE
then it will bypass the initial copy_table phase.
* tablesync sets up replication origin tracking in
LogicalRepSyncTableStart (similar as done for the apply worker). The
origin is advanced when first created.
* tablesync replication origin tracking is cleaned up during
DropSubscription and/or process_syncing_tables_for_apply.
* the DropSubscription cleanup code was enhanced (v7+) to take care of
crashed sync workers.
* minor updates to PG docs
TODO / Known Issues:
* address review comments
---
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0002-Tablesync-extra-logging.patch | application/octet-stream | 5.8 KB |
| v10-0001-Tablesync-Solution1.patch | application/octet-stream | 26.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-01-04 09:33:30 | Re: Single transaction in the tablesync worker? |
| Previous Message | Amit Kapila | 2021-01-04 09:08:52 | Re: Single transaction in the tablesync worker? |