Re: Docs: Always use true|false instead of sometimes on|off for the subscription options

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Docs: Always use true|false instead of sometimes on|off for the subscription options
Date: 2024-05-16 23:07:31
Message-ID: CAHut+Puvu_YEw4pYzPr6mmZSw0W7LUeL5UNZbgMfEAuxpephiQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 16, 2024 at 10:42 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Thu, 16 May 2024 at 19:05, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > On Thu, May 16, 2024 at 3:11 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > > If you want to do this, what's the reason to limit it to just this one
> > > page of the docs?
> >
> > Yeah, I had a vested interest in this one place because I've been
> > reviewing the other thread [1] that was mentioned above. If that other
> > thread chooses "true|false" then putting "true|false" adjacent to
> > another "on|off" will look silly.
>
> OK, looking a bit further I see this option is new to v17. After a
> bit more study of the sgml, I agree that it's worth changing this.
>
> I've pushed your patch.
>

Thanks very much for pushing. It was just a one-time thing -- I won't
go looking for more examples like it.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-05-16 23:11:17 Re: Postgres and --config-file option
Previous Message Jeff Davis 2024-05-16 22:54:52 Re: WAL record CRC calculated incorrectly because of underlying buffer modification