| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Documentation: warn about two_phase when altering a subscription |
| Date: | 2024-01-31 02:47:16 |
| Message-ID: | CAHut+PusXYSTFUqC103jGqgx54_3Neaj6509dak5Xs6ORCEahA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, thanks for the patch. Here are some review comments for v1
======
(below is not showing the links and other sgml rendering -- all those LGTM)
BEFORE
When altering the slot_name, the failover and two_phase properties
values of the named slot may differ from their counterparts failover
and two_phase parameters specified in the subscription. When creating
the slot, ensure the slot failover and two_phase properties match
their counterparts parameters values of the subscription.
SUGGESTION
When altering the slot_name, the failover and two_phase property
values of the named slot may differ from the counterpart failover and
two_phase parameters specified by the subscription. When creating the
slot, ensure the slot properties failover and two_phase match their
counterpart parameters of the subscription.
~
BEFORE
Otherwise, the slot on the publisher may behave differently from what
subscription's failover and two_phase options say: for example, the
slot on the publisher could ...
SUGGESTION:
Otherwise, the slot on the publisher may behave differently from what
these subscription options say: for example, the slot on the publisher
could ...
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Coleman | 2024-01-31 02:51:09 | Re: Parallelize correlated subqueries that execute within each worker |
| Previous Message | Peter Smith | 2024-01-31 01:57:24 | Re: Synchronizing slots from primary to standby |