From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
Date: | 2021-02-11 08:10:19 |
Message-ID: | CAHut+PuogrYQe4RFSg1_4ZxN1JA8ebQvKJdJZOaSUMUSYKqYPg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Feb 11, 2021 at 12:46 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Few other minor comments on
> v38-0004-Add-support-for-apply-at-prepare-time-to-built-i:
> ======================================================================
> 1.
> - * Mark the prepared transaction as valid. As soon as xact.c marks
> - * MyProc as not running our XID (which it will do immediately after
> - * this function returns), others can commit/rollback the xact.
> + * Mark the prepared transaction as valid. As soon as xact.c marks MyProc
> + * as not running our XID (which it will do immediately after this
> + * function returns), others can commit/rollback the xact.
>
> Why this change in this patch? Is it due to pgindent? If so, you need
> to exclude this change?
Fixed in V39.
>
> 2.
> @@ -78,7 +78,7 @@ logicalrep_write_commit(StringInfo out, ReorderBufferTXN *txn,
>
> pq_sendbyte(out, LOGICAL_REP_MSG_COMMIT);
>
> - /* send the flags field (unused for now) */
> + /* send the flags field */
> pq_sendbyte(out, flags);
>
> Is there a reason to change the above comment?
Fixed in V39.
----------
Please find attached the new 2PC patch set v39*
This fixes some recent feedback comments (see above).
----
Kind Regards,
Peter Smith.
Fujitsu Australia
Attachment | Content-Type | Size |
---|---|---|
v39-0002-Refactor-spool-file-logic-in-worker.c.patch | application/octet-stream | 3.6 KB |
v39-0003-Track-replication-origin-progress-for-rollbacks.patch | application/octet-stream | 3.9 KB |
v39-0004-Add-support-for-apply-at-prepare-time-to-built-i.patch | application/octet-stream | 37.8 KB |
v39-0005-Support-2PC-txn-subscriber-tests.patch | application/octet-stream | 60.4 KB |
v39-0001-Tablesync-V31.patch | application/octet-stream | 61.6 KB |
v39-0006-Support-2PC-txn-Subscription-option.patch | application/octet-stream | 35.1 KB |
v39-0007-Support-2PC-txn-tests-for-concurrent-aborts.patch | application/octet-stream | 16.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2021-02-11 08:21:28 | Re: Single transaction in the tablesync worker? |
Previous Message | Peter Eisentraut | 2021-02-11 08:02:40 | Re: SQL-standard function body |