| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, "Wei Wang (Fujitsu)" <wangw(dot)fnst(at)fujitsu(dot)com>, "Yu Shi (Fujitsu)" <shiy(dot)fnst(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |
| Date: | 2023-07-18 01:33:27 |
| Message-ID: | CAHut+Puiu21Nqgb3XKNx3SsT+jGkcSv2y8ZP0LuEKStKgMMATA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 18, 2023 at 11:25 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Tue, Jul 18, 2023 at 1:54 AM Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > PFA updated patches. Rebased 0003 with minor changes. Addressed Peter's reviews for 0001 and 0002 with some small comments below.
> >
>
> Thanks, I will take another look at these soon. FYI, the 0001 patch
> does not apply cleanly. It needs to be rebased again because
> get_worker_name() function was recently removed from HEAD.
>
Sorry, to be more correct -- it applied OK, but failed to build.
> replication/logical/worker.o: In function `InitializeLogRepWorker':
> /home/postgres/oss_postgres_misc/src/backend/replication/logical/worker.c:4605:
> undefined reference to `get_worker_name'
>
> ------
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii.Yuki@df.MitsubishiElectric.co.jp | 2023-07-18 01:35:53 | RE: Partial aggregates pushdown |
| Previous Message | Peter Smith | 2023-07-18 01:25:40 | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |