| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Subject: | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |
| Date: | 2025-02-12 23:18:10 |
| Message-ID: | CAHut+PuR4SRqW0mCUK9-s_utK3Lp_7hBuoy+z1ePgsoX2BniqQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Some review comments for v7-0001
======
src/bin/pg_basebackup/pg_createsubscriber.c
1.
+ /* Error if no databases were found on the source server */
+ if (num_rows == 0)
+ {
+ pg_log_error("no convertable databases found on the source server");
+ pg_log_error_hint("Ensure that there are non-template and
connectable databases on the source server.");
+ PQclear(res);
+ disconnect_database(conn, false);
+ exit(1);
+ }
1a.
The spelling is "convertible", not "convertable"
~
1b.
What does "convertible databases" mean here, and will that term make
sense to a user? How are we "converting" the source server databases;
AFAIK we are simply connecting to them and adding publications.
IMO a better choice of adjectives can be found below.
"no suitable databases found..."
"no appropriate databases found..."
"no eligible databases found..."
etc.
======
Kind Regards,
Peter Smith.
Fujitsu Australia.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2025-02-12 23:26:53 | Re: Unneeded volatile qualifier in fmgr.c |
| Previous Message | David G. Johnston | 2025-02-12 23:10:53 | Re: describe special values in GUC descriptions more consistently |